Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logs Export API #136

Merged
merged 4 commits into from
Nov 7, 2024
Merged

feat: Logs Export API #136

merged 4 commits into from
Nov 7, 2024

Conversation

shivam-pareek
Copy link
Contributor

Title:
The endpoints of Logs Export API have been integrated in the Node SDK

Related Issues:
#135

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 21, 2024
@csgulati09
Copy link
Collaborator

Can you run the following commands and resolve if there is anything:

  1. npm run format:check
  2. npm run format
  3. npm run lint:check
  4. npm run lint:fix

@csgulati09 csgulati09 self-requested a review October 30, 2024 14:43
@csgulati09
Copy link
Collaborator

We have a different structure in the API.
Can we make another class, so that we can have logs.exports Since we might have other methods under logs in future

@shivam-pareek
Copy link
Contributor Author

Can you run the following commands and resolve if there is anything:

  1. npm run format:check
  2. npm run format
  3. npm run lint:check
  4. npm run lint:fix

Ran and fixed!

@shivam-pareek
Copy link
Contributor Author

We have a different structure in the API. Can we make another class, so that we can have logs.exports Since we might have other methods under logs in future

Restructured accordingly.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@csgulati09 csgulati09 merged commit 931f905 into main Nov 7, 2024
1 check passed
@csgulati09 csgulati09 deleted the feat/logsExport branch November 7, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants